Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly disable the build of podman on openshift #1984

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Properly disable the build of podman on openshift #1984

merged 1 commit into from
Sep 6, 2024

Conversation

fedinskiy
Copy link
Contributor

Summary

Follow-up to #1981 which id double verified on our Jenkins

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik
Copy link
Member

Properly disable the build of podman on openshift

I love that we did pre-flight PR. Let's pretend it was intentional, otherwise I'll look like lousy reviewer.

@fedinskiy
Copy link
Contributor Author

I love that we did pre-flight PR.

Well, we ran OC tests, but they didn't catch this

@fedinskiy fedinskiy marked this pull request as ready for review September 6, 2024 10:31
@fedinskiy
Copy link
Contributor Author

weekly run on JVM and stable Openshift processed this module without any issues, so this can be merged

michalvavrik
michalvavrik approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO changes are correct.

@michalvavrik michalvavrik merged commit 5697c93 into main Sep 6, 2024
8 checks passed
@michalvavrik michalvavrik deleted the fix/weekly branch September 6, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalvavrik michalvavrik michalvavrik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fedinskiy @michalvavrik