Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure AsyncFile gets closed #1968

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Make sure AsyncFile gets closed #1968

merged 1 commit into from
Sep 4, 2024

Conversation

rsvoboda
Copy link
Member

@rsvoboda rsvoboda commented Sep 3, 2024 •
edited
Loading

Make sure AsyncFile gets closed

Trigger: quarkusio/quarkus#41811

PASS: mvn clean verify -f http/http-advanced-reactive -Dit.test=DownloadResourceIT -Dquarkus.platform.version=3.12.3
FAIL: mvn clean verify -f http/http-advanced-reactive -Dit.test=DownloadResourceIT -Dquarkus.platform.version=3.12.2

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@rsvoboda rsvoboda requested a review from fedinskiy September 3, 2024 11:15
@michalvavrik michalvavrik merged commit a416c75 into quarkus-qe:main Sep 4, 2024
8 checks passed
@jedla97 jedla97 added this to the 3.8 milestone Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedinskiy fedinskiy fedinskiy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.8
Development

Successfully merging this pull request may close these issues.
4 participants
@rsvoboda @fedinskiy @jedla97 @michalvavrik