-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating PR CI to run full native if no changes in modules are detected #1910
Conversation
dbc2f7c
to
4cdb473
Compare
bbd719c
to
88ecbb2
Compare
Following jobs contain at least one flaky test: 'PR - Linux - JVM build - Latest Version' |
Flaky test is |
88ecbb2
to
5a25e07
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Following jobs contain at least one flaky test: 'PR - Linux - JVM build - Latest Version' |
Ready to merge? |
yes, merged |
Summary
Adding the logic to run the Linux native run if no modules are detected. This change not include windows as on PRs we don't even run native windows.
I decided make
NATIVE_MODULES_MAVEN_PARAM
on multiple row as it's more readable. So I need to clean it withtr -d -s '\n' ' '
for env variable to be one line string.Also updating the modules load for native execution time be similar for all modules.
Please select the relevant options.
run tests
phrase in comment)Checklist: