Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating PR CI to run full native if no changes in modules are detected #1910

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

jedla97
Copy link
Member

@jedla97 jedla97 commented Jul 26, 2024

Summary

Adding the logic to run the Linux native run if no modules are detected. This change not include windows as on PRs we don't even run native windows.

I decided make NATIVE_MODULES_MAVEN_PARAM on multiple row as it's more readable. So I need to clean it with tr -d -s '\n' ' ' for env variable to be one line string.

Also updating the modules load for native execution time be similar for all modules.

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@jedla97 jedla97 force-pushed the enable-full-native-for-PR branch from dbc2f7c to 4cdb473 Compare July 26, 2024 18:52
@jedla97 jedla97 force-pushed the enable-full-native-for-PR branch 5 times, most recently from bbd719c to 88ecbb2 Compare August 1, 2024 15:31
@github-actions github-actions bot added the triage/flaky-test Signal that flaky tests were detected during CI run label Aug 1, 2024
Copy link

github-actions bot commented Aug 1, 2024

Following jobs contain at least one flaky test: 'PR - Linux - JVM build - Latest Version'

@jedla97
Copy link
Member Author

jedla97 commented Aug 1, 2024

Flaky test is io.quarkus.ts.messaging.kafka.reactive.streams.KafkaGratefulShutdownIT.testConnection

@jedla97 jedla97 requested a review from gtroitsk August 1, 2024 22:03
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@jedla97 jedla97 force-pushed the enable-full-native-for-PR branch from 88ecbb2 to 5a25e07 Compare August 5, 2024 11:19
Copy link
Member

@gtroitsk gtroitsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

github-actions bot commented Aug 5, 2024

Following jobs contain at least one flaky test: 'PR - Linux - JVM build - Latest Version'

@rsvoboda
Copy link
Member

rsvoboda commented Aug 6, 2024

Ready to merge?

@gtroitsk gtroitsk merged commit 4341cd9 into quarkus-qe:main Aug 6, 2024
14 checks passed
@gtroitsk
Copy link
Member

gtroitsk commented Aug 6, 2024

Ready to merge?

yes, merged

@jedla97 jedla97 added this to the 3.8 milestone Sep 3, 2024
@jedla97 jedla97 mentioned this pull request Sep 3, 2024
9 tasks
@michalvavrik michalvavrik removed triage/backport-3.2 RHBQ Ghost LTS release triage/flaky-test Signal that flaky tests were detected during CI run labels Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants