Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix possible CI (detect modules) failure because of the special characters in filename #1894

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Fix possible CI (detect modules) failure because of the special characters in filename #1894

merged 1 commit into from
Jul 19, 2024

Conversation

jedla97
Copy link
Member

@jedla97 jedla97 commented Jul 18, 2024

Summary

This is port from #1866 because the name of file contains special character. This wasn't caught on main because of some wierd bug with CI where it sometimes don't detecting files.

Don't expect this happend much often but it's better to have it in main also

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@jedla97 jedla97 requested a review from jcarranzan July 18, 2024 17:34
@jedla97 jedla97 changed the title Fix failing CI (detect modules) because of the special characters in filename Fix possible CI (detect modules) failure because of the special characters in filename Jul 18, 2024
jcarranzan
jcarranzan approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@jcarranzan jcarranzan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the failures are not related, so let's merge it.

@jcarranzan jcarranzan merged commit 569452e into quarkus-qe:main Jul 19, 2024
6 of 9 checks passed
@jedla97 jedla97 deleted the fix-ci-detect-modules branch December 10, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcarranzan jcarranzan jcarranzan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jedla97 @jcarranzan