Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update otel properties the Quarkus bumped the otel #1888

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

jedla97
Copy link
Member

@jedla97 jedla97 commented Jul 16, 2024

Summary

The Quarkus bumped Otel quarkusio/quarkus#41521. This update have some breaking changes in HTTP semantic conventions.

I also look through the codebase and didn't find any occurencies of changed attributes. It's possible that there will be another fail because of the Otel bump.

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@jedla97 jedla97 force-pushed the fix-javaee-gettingstarted branch from acfc447 to 29dd1c7 Compare July 16, 2024 12:06
@jedla97 jedla97 force-pushed the fix-javaee-gettingstarted branch from 29dd1c7 to 3d83fe2 Compare July 16, 2024 12:50
@jedla97 jedla97 marked this pull request as ready for review July 16, 2024 12:50
@jedla97 jedla97 requested a review from michalvavrik July 16, 2024 13:44
Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks!

@michalvavrik michalvavrik merged commit 9714300 into quarkus-qe:main Jul 16, 2024
8 checks passed
@jedla97 jedla97 deleted the fix-javaee-gettingstarted branch December 10, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants