-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test coverage for Keep the URIs in the metrics tag with 302 and 404 patterns #1838
Merged
michalvavrik
merged 1 commit into
quarkus-qe:main
from
jcarranzan:http-metric-redirection-not-found
Jun 13, 2024
Merged
Test coverage for Keep the URIs in the metrics tag with 302 and 404 patterns #1838
michalvavrik
merged 1 commit into
quarkus-qe:main
from
jcarranzan:http-metric-redirection-not-found
Jun 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...ometer-prometheus/src/main/java/io/quarkus/ts/micrometer/prometheus/PathPatternResource.java
Outdated
Show resolved
Hide resolved
...r-prometheus/src/test/java/io/quarkus/ts/micrometer/prometheus/HttpPathMetricsPatternIT.java
Show resolved
Hide resolved
...r-prometheus/src/test/java/io/quarkus/ts/micrometer/prometheus/HttpPathMetricsPatternIT.java
Outdated
Show resolved
Hide resolved
...r-prometheus/src/test/java/io/quarkus/ts/micrometer/prometheus/HttpPathMetricsPatternIT.java
Outdated
Show resolved
Hide resolved
...r-prometheus/src/test/java/io/quarkus/ts/micrometer/prometheus/HttpPathMetricsPatternIT.java
Show resolved
Hide resolved
...r-prometheus/src/test/java/io/quarkus/ts/micrometer/prometheus/HttpPathMetricsPatternIT.java
Show resolved
Hide resolved
...r-prometheus/src/test/java/io/quarkus/ts/micrometer/prometheus/HttpPathMetricsPatternIT.java
Outdated
Show resolved
Hide resolved
jcarranzan
force-pushed
the
http-metric-redirection-not-found
branch
2 times, most recently
from
June 13, 2024 09:52
1118728
to
21ba9a1
Compare
...r-prometheus/src/test/java/io/quarkus/ts/micrometer/prometheus/HttpPathMetricsPatternIT.java
Outdated
Show resolved
Hide resolved
...r-prometheus/src/test/java/io/quarkus/ts/micrometer/prometheus/HttpPathMetricsPatternIT.java
Show resolved
Hide resolved
jcarranzan
force-pushed
the
http-metric-redirection-not-found
branch
from
June 13, 2024 13:59
31d4066
to
040144f
Compare
michalvavrik
approved these changes
Jun 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm provided CI is green, good job
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test coverage for QUARKUS-4430 quarkusio/quarkus#39583
TP: quarkus-qe/quarkus-test-plans#177
Please select the relevant options.
run tests
phrase in comment)Checklist: