Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backports-3.8.5 coverage for QuarkusCliPomIntegrity and GzipMaxInput #1837

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

jcarranzan
Copy link
Contributor

@jcarranzan jcarranzan commented Jun 12, 2024

Summary

Adding TD for the next backports for 3.8 branch:

These backports changes have been done also in main branch ---> #1802

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

Sorry, something went wrong.

@jcarranzan jcarranzan force-pushed the backports-3.8.5 branch 2 times, most recently from acac357 to d662b79 Compare June 12, 2024 07:39
@jcarranzan jcarranzan requested a review from fedinskiy June 12, 2024 07:39
@jcarranzan jcarranzan marked this pull request as ready for review June 12, 2024 07:40
@fedinskiy
Copy link
Contributor

@jcarranzan isn't this PR a backport? If yes, please:

  1. Check the relevant checkbox in the description
  2. Provide links the original PR(s)

@jcarranzan
Copy link
Contributor Author

The native failure is because of --> https://issues.redhat.com/browse/QUARKUS-4570

@jcarranzan
Copy link
Contributor Author

I've disabled the test GzipMaxInputIT.sendMaximumAllowedPayload because this issue in native mode https://issues.redhat.com/browse/QUARKUS-4570 (already fixed in main branch)

Copy link
Member

@jedla97 jedla97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the testing of 3.8.5 should start soon is something what blocking this PR to be merged?
+ I just one comment as to disable that one test only on native should be enough

@jcarranzan jcarranzan merged commit 25ef909 into quarkus-qe:3.8 Jun 21, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants