Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coverage for the quarkus-spring-boot-properties Quarkus extension #173

Merged
merged 1 commit into from
Aug 17, 2021

Conversation

Sgitario
Copy link
Contributor

Exploratory testing for the quarkus-spring-boot-properties Quarkus extension. The application consists of a REST endpoint
with some different approaches to inject properties.

Current limitations:

Fix #172

@Sgitario Sgitario requested a review from jsmrcka August 12, 2021 10:53
Exploratory testing for the `quarkus-spring-boot-properties` Quarkus extension. The application consists of a REST endpoint
with some different approaches to inject properties.

Current limitations:
- Relaxing name convention is not supported and it won't be supported: quarkusio/quarkus#12483
- The annotation `@ConstructorBinding` is not supported yet: quarkusio/quarkus#19364
@Sgitario Sgitario force-pushed the add_spring_properties branch from 607d2bb to faad4eb Compare August 16, 2021 11:17
Copy link
Contributor

@jsmrcka jsmrcka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks fine.

What's the situation on quarkusio/quarkus#19364? The feature might become supported in the future, yet there is no mention of it in the code.
On the other hand, there are 3 other features (quarkusio/quarkus#19365, quarkusio/quarkus#19366, quarkusio/quarkus#19368), which are almost certainly not going to be supported, but they are mentioned in the code and a coverage for them is present in the form of commented-out code.

@Sgitario
Copy link
Contributor Author

The code looks fine.

What's the situation on quarkusio/quarkus#19364? The feature might become supported in the future, yet there is no mention of it in the code.
On the other hand, there are 3 other features (quarkusio/quarkus#19365, quarkusio/quarkus#19366, quarkusio/quarkus#19368), which are almost certainly not going to be supported, but they are mentioned in the code and a coverage for them is present in the form of commented-out code.

As I created the issues myself, I will cover those scenarios for sure. About the three other issues... I don't think it's 100% sure that it won't be supported (not in the short term for sure, but maybe in the long).

@Sgitario Sgitario merged commit 506af80 into quarkus-qe:main Aug 17, 2021
@Sgitario Sgitario deleted the add_spring_properties branch August 17, 2021 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add coverage for quarkus-spring-boot-properties
2 participants