Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename rest-client extension #1623

Merged
merged 1 commit into from
Jan 20, 2024
Merged

Conversation

mocenas
Copy link
Contributor

@mocenas mocenas commented Jan 19, 2024

Summary

quarkus-rest-client extension got renamed in the upstream to quarkus-resteasy-client. Rename it in analytics test.
Rename was done in PR quarkusio/quarkus#38190

This should be renamed in quarkus 3.7 forth. Reactive version will probably also be renamed the future.

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@mocenas mocenas requested a review from fedinskiy January 19, 2024 12:22
@rsvoboda
Copy link
Member

Isn't this handled by #1617?

@mocenas
Copy link
Contributor Author

mocenas commented Jan 19, 2024

Isn't this handled by #1617?

It is. Sorry I didn't looked at that one. Thing is, even relocations does not fix it now. So either this one or #1617 should be merged to fix this problem. Our GH daily pipeline is already failing because of this. Compiling quarkus locally with -Prelocations does not help.

Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this handled by #1617?

It is. Sorry I didn't looked at that one. Thing is, even relocations does not fix it now. So either this one or #1617 should be merged to fix this problem. Our GH daily pipeline is already failing because of this. Compiling quarkus locally with -Prelocations does not help.

that's compelling reason

@michalvavrik
Copy link
Member

to sum it up @rsvoboda - 99 % of cases this PR will cause no conflicts (it changes names of 3 strings inside build time analytics modules, no pom), I think we need to avoid failing tests so that daily build is run in full. It's different to my PR. I'll merge it, if you disagree, please click to "revert" and I'll approve it. Thanks

@michalvavrik michalvavrik merged commit 4faf1cf into quarkus-qe:main Jan 20, 2024
7 checks passed
@mocenas mocenas deleted the rename_extensions branch January 22, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants