Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.2] Fix service binding PostgreSQL tests on OpenShift 4.14 as cluster service versions are loaded lazily #1547

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented Nov 28, 2023

Summary

Behavior between OCP 4.11 and OCP 4.14 differs in that cluster service versions are added to newly created project one by one (not at once) and it takes longer.

Native OCP failure is very much as what I see on main (but there even in JVM mode), I'll get back to it, but it is not related to changes here.

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik
Copy link
Member Author

run tests

@michalvavrik michalvavrik requested a review from mjurc November 28, 2023 11:48
Copy link
Member

@mjurc mjurc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the refactoring.

@mjurc
Copy link
Member

mjurc commented Nov 28, 2023

run tests

@mjurc mjurc merged commit 2c051a3 into quarkus-qe:3.2 Nov 28, 2023
8 checks passed
@mjurc
Copy link
Member

mjurc commented Nov 28, 2023

@michalvavrik can you cherry-pick this fix into main too?

@michalvavrik michalvavrik deleted the 3.2-fix/fix-pg-ocp414 branch November 28, 2023 12:28
@michalvavrik
Copy link
Member Author

@michalvavrik can you cherry-pick this fix into main too?

problem with main branch is that you can't test it there. and the issue why these tests are disabled is also closed. I need to debug it when I have a time. I won't forget, no worry.

michalvavrik added a commit to michalvavrik/quarkus-test-suite that referenced this pull request Jan 8, 2024
Enables PG SB test as quarkusio/quarkus#37461 is fixed, run it against 4.14 from my workstation and works. Ports quarkus-qe#1547 as the test fails without it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants