-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Redis cache tests and bump Redis version #1524
Conversation
run tests |
OCP failures are not related, problem is in our snapshot deployment job. |
@jedla97 yesterday this looked good to me, but I need to go through it again. Please rebase on current and re-run OCP tests (there was some fix on our infra). Thanks |
0e528a8
to
91feaf6
Compare
run tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very nice work, please add section to the README regarding new module. I'm also not psyched about adding this to the root modules considering OOM at native failures, but that should be fixed separately (for you are adding it next to caffeine, your PR is fine).
91feaf6
to
6774a56
Compare
run tests |
@michalvavrik I updated README + add the module to cache profile. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We can fix the typo in a separate commit if you wish. This can go in as soon as CI is green.
Most of the tests are reused from caffeine module anshould cover similar scenarios as spring che and caffeine cache.
6774a56
to
7c0871b
Compare
@jedla97 let's not re-run OCP tests, I'll look to Jenkins on results of the ones you triggered previously. You can't cancel them from here. |
Summary
Hi, this PR main objective was cover quarkusio/quarkus#35680. As it was need standalone module I added some test which was overlapping between caffeine cache and spring cache. Test to cover 35680 is
quteShouldThrowError
. Tested manually the redis cache with rest of the api and I saw it cached in Redis (usedredis-cli keys "*"
).In standalone commit is update of Redis version (Quarkus dev mode using latest).
Please select the relevant options.
run tests
phrase in comment)Checklist: