-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for check SSE reactive empty response data #1517
Conversation
ece6276
to
806e406
Compare
My impression is that RESTEasy Classic and SSE don't go together too well: #1511 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You checked off follow the best practices https://cbea.ms/git-commit/
but in https://cbea.ms/git-commit/ I can see rule number 4. Do not end the subject line with a period Can you please try to provide more descriptive PR title? I know it's hard, I hardly ever do it right, but I think you can do better. Thanks
...nced-reactive/src/main/java/io/quarkus/ts/http/advanced/reactive/SseEventUpdateResource.java
Outdated
Show resolved
Hide resolved
...nced-reactive/src/main/java/io/quarkus/ts/http/advanced/reactive/SseEventUpdateResource.java
Show resolved
Hide resolved
...nced-reactive/src/main/java/io/quarkus/ts/http/advanced/reactive/SseEventUpdateResource.java
Outdated
Show resolved
Hide resolved
...nced-reactive/src/main/java/io/quarkus/ts/http/advanced/reactive/SseEventUpdateResource.java
Outdated
Show resolved
Hide resolved
...nced-reactive/src/main/java/io/quarkus/ts/http/advanced/reactive/SseEventUpdateResource.java
Outdated
Show resolved
Hide resolved
...-reactive/src/test/java/io/quarkus/ts/http/advanced/reactive/BaseHttpAdvancedReactiveIT.java
Outdated
Show resolved
Hide resolved
...-reactive/src/test/java/io/quarkus/ts/http/advanced/reactive/BaseHttpAdvancedReactiveIT.java
Outdated
Show resolved
Hide resolved
806e406
to
63a9de1
Compare
@jedla97 lgtm (+ please address note above on PR title), but let's wait to quarkusio/quarkus#37035 and enable native test before this go in |
63a9de1
to
984dbcf
Compare
@michalvavrik Title updated, Last push was just change commit typo. No problem waiting. Hope it will be quick |
@jedla97 I'm starting to think upstream PR won't go in anytime soon. Please rebase so that we can get this in. |
984dbcf
to
de64387
Compare
run tests |
@michalvavrik rebased + I run test as the |
Summary
Adding the test based on scenario from quarkusio/quarkus#35966. When developing it there are some issues so for now it's disabled (quarkusio/quarkus#37033 and quarkusio/quarkus#36986).
Test should run on ocp as well but as it it disable I don't see much point to run it now.
Maybe it would be nice to add this scenario (with empty request) to http-advanced (non-reactive)? There is recent test for SSE but with this there will need be some small adjustment to it. WDYT?
Please select the relevant options.
run tests
phrase in comment)Checklist: