Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force Openapi to use non-management interface #1318

Merged
merged 1 commit into from
Jul 14, 2023

Conversation

fedinskiy
Copy link
Contributor

Summary

Due to a change[1] made upstream OpenAPI is now deployed on management interface by default. This breaks our tests, so we should use an option to disable this behavior (and verify, that this option works).

[1] quarkusio/quarkus#34353

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

Due to a change[1] made upstream  OpenAPI is now deployed
on management interface by default. This breaks our tests, so we should
use an option to disable this behavior (and verify, that this option
works).

[1] quarkusio/quarkus#34353
@fedinskiy fedinskiy requested a review from michalvavrik July 14, 2023 11:34
Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thanks for the fix

@fedinskiy
Copy link
Contributor Author

run tests

@fedinskiy fedinskiy merged commit 59a7a29 into quarkus-qe:main Jul 14, 2023
@fedinskiy fedinskiy deleted the fix/daily branch July 14, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants