Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cover GitOps friendly Kubernetes additions #1313

Merged
merged 1 commit into from
Jul 14, 2023
Merged

Cover GitOps friendly Kubernetes additions #1313

merged 1 commit into from
Jul 14, 2023

Conversation

fedinskiy
Copy link
Contributor

Summary

Quarkus 3 allows making K8s manifests more Git-friendly [1]
We cover them with these changes, with a single exception[2]

[1] quarkusio/quarkus#31373
[2] quarkusio/quarkus#34673

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@fedinskiy fedinskiy requested a review from michalvavrik July 11, 2023 14:49
@fedinskiy
Copy link
Contributor Author

run tests

@michalvavrik
Copy link
Member

I've seen these OC failures today already, they are not related to changes.

@michalvavrik
Copy link
Member

michalvavrik commented Jul 11, 2023 •
edited
Loading

More specifically, I have seen same failures in run OC JVM run number 90, so I know OpenShiftConfigSourcePriorityIT failure is not related. On the other hand, OpenShiftConfigSourcePriorityIT is needed for this PR and we can't test it. I can reproduce issue on our main branch. It is quite late, not sure if I'm going to report or analyze it today.

@fedinskiy
Copy link
Contributor Author

@michalvavrik I will handle these changes here: #1314.
I suggest to keep this PR open, until the second one is merged

@michalvavrik
Copy link
Member

Ok @fedinskiy but it looks like bug in Quarkus to me. I'm just trying to create standalone reproduce. If you already know where the problem is, I will stop.

@michalvavrik
Copy link
Member

On second thought, I'm going to sleep.

@fedinskiy
Copy link
Contributor Author

run tests

@michalvavrik
Copy link
Member

Failure related File kubernetes.yml does not contains commit ids! ==> expected: <true> but was: <false>

@fedinskiy
Copy link
Contributor Author

fedinskiy commented Jul 13, 2023 •
edited
Loading

This is very a weird behavior, which I can not reproduce manually on the latest 999-SNASHOT

run tests

@fedinskiy
Copy link
Contributor Author

run tests

@michalvavrik
Copy link
Member

Hmm, still there :-/

@fedinskiy
Cover GitOps friendly Kubernetes additions
c46a790 
Quarkus 3 allows making K8s manifests more Git-friendly [1]
We cover them with these changes, with a single exception[2]

[1] quarkusio/quarkus#31373
[2] quarkusio/quarkus#34673
@fedinskiy
Copy link
Contributor Author

run tests

michalvavrik
michalvavrik approved these changes Jul 14, 2023
View reviewed changes
Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fedinskiy fedinskiy merged commit f192ceb into quarkus-qe:main Jul 14, 2023
@fedinskiy fedinskiy deleted the feature/gitops branch July 14, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalvavrik michalvavrik michalvavrik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fedinskiy @michalvavrik