Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Oracle Flyway migration by adding org.flywaydb:flyway-database-oracle to Vert.X SQL module #1303

Conversation

michalvavrik
Copy link
Member

Summary

Flyway has been bumped quarkusio/quarkus#34262 to 9.20.0 and our daily build fails over org.flywaydb.core.api.FlywayException: Unsupported Database: Oracle 21.3. In order to pass this condition https://github.com/flyway/flyway/blob/5bda08d4b101b30ad6eb9c7ffd6b10a416d5f6ef/flyway-core/src/main/java/org/flywaydb/core/internal/database/DatabaseTypeRegister.java#L100C71-L100C71 we need https://github.com/flyway/flyway/blob/5bda08d4b101b30ad6eb9c7ffd6b10a416d5f6ef/flyway-database-oracle/src/main/java/org/flywaydb/database/oracle/OracleDatabaseType.java#L99 from flyway-database-oracle dependency.

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik michalvavrik requested a review from mjurc July 7, 2023 10:59
Copy link
Member

@mjurc mjurc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix

@mjurc mjurc merged commit 9a9c553 into quarkus-qe:main Jul 7, 2023
@michalvavrik michalvavrik deleted the feature/add-flyway-oracle-to-fix-daily-build branch July 7, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants