Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix corrupted channel trouble with native binary build #1233

Merged
merged 1 commit into from
May 19, 2023

Conversation

rsvoboda
Copy link
Member

@rsvoboda rsvoboda commented May 19, 2023

Fix corrupted channel trouble with native binary build

Details in quarkus-qe/quarkus-test-framework#785

Relates to quarkus-qe/quarkus-test-framework#786

Example command: mvn clean verify -Dit.test=WebSocketsClientIT -f websockets/websockets-client -Dnative -Dquarkus.native.container-build=false

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rsvoboda
Copy link
Member Author

rsvoboda commented May 19, 2023

Failure is not related to the changes

Error:  Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 75.937 s <<< FAILURE! - in io.quarkus.ts.http.graphql.telemetry.GraphQLTelemetryIT
Error:  io.quarkus.ts.http.graphql.telemetry.GraphQLTelemetryIT.verifyTelemetry  Time elapsed: 63.813 s  <<< ERROR!
org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a 
  io.quarkus.ts.http.graphql.telemetry.GraphQLTelemetryIT expected: <1> but was: <2> within 1 minutes.

@michalvavrik michalvavrik merged commit ff57517 into quarkus-qe:main May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants