Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable OpenAPI definition check for allowed roles in security scheme #1141

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Disable OpenAPI definition check for allowed roles in security scheme #1141

merged 1 commit into from
Apr 3, 2023

Conversation

michalvavrik
Copy link
Member

Summary

Disables assertion of roles allowed to access path in generated OpenAPI definition. We already had to disable same check for OIDC classic and now that daily build # 779 failed, we know it is also affected by quarkusio/quarkus#32112

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik
Disable OpenAPI definition check for allowed roles in security scheme
3c9a572 
Disables assertion of roles allowed to access path in generated OpenAPI definition. We already had to [disable same check for OIDC classic](quarkus-qe#1129) and now that [daily build # 779 failed](https://github.com/quarkus-qe/quarkus-test-suite/actions/runs/4585690826/jobs/8098110705), we know it is also affected by quarkusio/quarkus#32112
@michalvavrik michalvavrik force-pushed the feature/disable-openapi-rolesallowed-check-in-reactive branch from 37c6bbe to 3c9a572 Compare April 2, 2023 07:55
@michalvavrik michalvavrik requested a review from pjgg April 2, 2023 07:56
pjgg
pjgg approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@pjgg pjgg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pjgg pjgg merged commit bbcfe42 into quarkus-qe:main Apr 3, 2023
@michalvavrik michalvavrik deleted the feature/disable-openapi-rolesallowed-check-in-reactive branch April 3, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjgg pjgg pjgg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michalvavrik @pjgg