Enable tests for QUARKUS-1218: Regression issue for @ConfigMapping

The issue quarkusio/quarkus#19448 was fixed by quarkusio/quarkus#19937
quarkus-qe · Sep 8, 2021 · fa77195 · fa77195
1 parent 17f6c57
commit fa77195
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/...config/src/main/java/io/quarkus/ts/spring/cloud/config/ConfigMappingGreetingResource.java b/...config/src/main/java/io/quarkus/ts/spring/cloud/config/ConfigMappingGreetingResource.java
@@ -1,13 +1,13 @@
 package io.quarkus.ts.spring.cloud.config;
 
+import javax.inject.Inject;
 import javax.ws.rs.GET;
 import javax.ws.rs.Path;
 
 @Path("/custom-mapping/hello")
 public class ConfigMappingGreetingResource {
 
-    // TODO Disabled because https://github.com/quarkusio/quarkus/issues/19448
-    // @Inject
+    @Inject
     CustomMessageConfig config;
 
     @GET

diff --git a/...ing-cloud-config/src/main/java/io/quarkus/ts/spring/cloud/config/CustomMessageConfig.java b/...ing-cloud-config/src/main/java/io/quarkus/ts/spring/cloud/config/CustomMessageConfig.java
@@ -1,7 +1,8 @@
 package io.quarkus.ts.spring.cloud.config;
 
-// TODO Disabled because https://github.com/quarkusio/quarkus/issues/19448
-// @ConfigMapping(prefix = "custom")
+import io.smallrye.config.ConfigMapping;
+
+@ConfigMapping(prefix = "custom")
 public interface CustomMessageConfig {
 
     String message();

diff --git a/...ing-cloud-config/src/test/java/io/quarkus/ts/spring/cloud/config/SpringCloudConfigIT.java b/...ing-cloud-config/src/test/java/io/quarkus/ts/spring/cloud/config/SpringCloudConfigIT.java
@@ -3,6 +3,7 @@
 import static org.hamcrest.Matchers.is;
 
 import org.apache.http.HttpStatus;
+import org.junit.jupiter.api.Tag;
 import org.junit.jupiter.params.ParameterizedTest;
 import org.junit.jupiter.params.provider.ValueSource;
 
@@ -24,8 +25,9 @@ public class SpringCloudConfigIT {
             .withProperty("quarkus.profile", "SpringCloudConfigIT")
             .withProperty("quarkus.spring-cloud-config.url", () -> spring.getHost() + ":" + spring.getPort());
 
+    @Tag("QUARKUS-1218")
     @ParameterizedTest
-    @ValueSource(strings = { "/jaxrs", "/spring" }) // TODO Disabled because https://github.com/quarkusio/quarkus/issues/19448: "/custom-mapping" })
+    @ValueSource(strings = { "/jaxrs", "/spring", "/custom-mapping" })
     public void shouldGetExpectedHelloMessage(String rootPath) {
         app.given().get(rootPath + "/hello").then()
                 .statusCode(HttpStatus.SC_OK)