Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QUARKUS 2284 - Support using OpenShift Serverless Functions #95

Merged
merged 1 commit into from
Sep 22, 2022
Merged

QUARKUS 2284 - Support using OpenShift Serverless Functions #95

merged 1 commit into from
Sep 22, 2022

Conversation

michalvavrik
Copy link
Member

Adds a test plan for QUARKUS-2284.

@michalvavrik michalvavrik requested a review from mjurc September 14, 2022 23:40
@michalvavrik michalvavrik self-assigned this Sep 14, 2022
@michalvavrik michalvavrik force-pushed the feature/funqy-knative-eventing-QUARKUS-2284 branch from 9d93ca9 to d0e5aa0 Compare September 14, 2022 23:45
mjurc
mjurc requested changes Sep 15, 2022
View reviewed changes
QUARKUS-2284.md Outdated Show resolved Hide resolved
QUARKUS-2284.md Outdated Show resolved Hide resolved
QUARKUS-2284.md Outdated Show resolved Hide resolved
@michalvavrik michalvavrik force-pushed the feature/funqy-knative-eventing-QUARKUS-2284 branch from d0e5aa0 to 708fd59 Compare September 15, 2022 18:05
@michalvavrik michalvavrik requested a review from mjurc September 16, 2022 09:02
@michalvavrik michalvavrik force-pushed the feature/funqy-knative-eventing-QUARKUS-2284 branch from 708fd59 to be35c5d Compare September 21, 2022 23:30
@michalvavrik
Copy link
Member Author

michalvavrik commented Sep 21, 2022 •
edited
Loading

@mjurc I rewrote certain parts as we should use oc rather than kn func. Works quite nicely, I had to use admin user for my tests, but I think it will be possible to give standard user rights to install Knative Eventing.

@michalvavrik michalvavrik force-pushed the feature/funqy-knative-eventing-QUARKUS-2284 branch from be35c5d to d7f9a8d Compare September 21, 2022 23:36
@michalvavrik michalvavrik force-pushed the feature/funqy-knative-eventing-QUARKUS-2284 branch from d7f9a8d to 255a19d Compare September 21, 2022 23:41
mjurc
mjurc approved these changes Sep 22, 2022
View reviewed changes
Copy link
Member

@mjurc mjurc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update + addressing the concerns.

LGTM.

@mjurc mjurc merged commit 4ad9fc8 into quarkus-qe:main Sep 22, 2022
@michalvavrik michalvavrik deleted the feature/funqy-knative-eventing-QUARKUS-2284 branch September 22, 2022 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjurc mjurc mjurc approved these changes

Assignees

@michalvavrik michalvavrik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michalvavrik @mjurc