Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test plan of JSON payloads in Quarkus REST endpoints #179

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

jcarranzan
Copy link
Contributor

Links

JIRA:
QQE-379

Quarkus documentation:

Reminder for considerable topics

  • Make sure you have considered the following areas when preparing the test plan:

    • Logging
    • Tracing
    • Metrics
    • Security
    • OpenAPI
    • Data sources
    • Frontend
    • Qute

@jcarranzan jcarranzan requested a review from mjurc July 2, 2024 09:44
@jcarranzan jcarranzan force-pushed the QQE-379 branch 2 times, most recently from 842d464 to 33ca0ca Compare July 2, 2024 10:32
QQE-379.md Outdated Show resolved Hide resolved
QQE-379.md Outdated Show resolved Hide resolved
@jcarranzan jcarranzan force-pushed the QQE-379 branch 2 times, most recently from 14424cf to ad7a624 Compare July 12, 2024 08:28
@jcarranzan jcarranzan marked this pull request as ready for review July 12, 2024 08:28
@jcarranzan jcarranzan force-pushed the QQE-379 branch 2 times, most recently from 03f64d7 to e135bc5 Compare July 17, 2024 08:23
@jcarranzan jcarranzan requested a review from mjurc July 17, 2024 08:39
@jedla97
Copy link
Member

jedla97 commented Jul 17, 2024

As I go review the code in TS i read the TP as well. Could you add or at least test how these tests impact the time execution? As you setting RestService with only two classes so it will be probably need to be compiled to native independently.

@mjurc
Copy link
Member

mjurc commented Jul 18, 2024

Agree with @jedla97 here

@jcarranzan
Copy link
Contributor Author

Ok , I've updated the TD to try test both libraries, and I'll keep with @jedla97 suggestion, thanks.

Copy link
Member

@mjurc mjurc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fixes

@mjurc mjurc merged commit 362e594 into quarkus-qe:main Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants