-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QUARKUS-2994|JDK 21 support #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjurc
requested changes
Jan 16, 2024
mjurc
requested changes
Jan 17, 2024
fedinskiy
force-pushed
the
java21
branch
2 times, most recently
from
January 22, 2024 16:23
3a10545
to
31fe6b6
Compare
mjurc
requested changes
Jan 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the one thing, LGTM
@rsvoboda please have a look afterwards
rsvoboda
requested changes
Jan 30, 2024
fedinskiy
force-pushed
the
java21
branch
3 times, most recently
from
January 31, 2024 12:32
6822d4c
to
56d4aec
Compare
rsvoboda
approved these changes
Feb 1, 2024
Needing approval from @mjurc to be able to merge this PR |
mjurc
approved these changes
Feb 1, 2024
Thanks for the contribution. |
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links
JIRA: https://issues.redhat.com/browse/QUARKUS-2994
Quarkus documentation: https://quarkus.io/blog/quarkus-3-5-0-released/
Reminder for considerable topics
Make sure you have considered the following areas when preparing the test plan: