Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Dependabot bump Quarkus BOM #999

Conversation

michalvavrik
Copy link
Member

Summary

I think we should let Dependabot bump Quarkus BOM as we keep forgetting doing it (and there is no point of doing it manually). Dependabot has ignore option that will allow us to skip bumps as long as we want to stick to old version and it always requires QE team approval anyway, so... I thought it wasn't working due to bug dependabot/dependabot-core#7309 but now I hear that Quarkus Superheroes project has same setup. So my only explanation is that it can be related to quarkus-maven-plugin ignore rule. No idea why it was added here #147.

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik michalvavrik mentioned this pull request Dec 21, 2023
10 tasks
Copy link
Member

@rsvoboda rsvoboda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, let's try it.

@rsvoboda rsvoboda merged commit f0bb3a6 into quarkus-qe:main Dec 22, 2023
7 checks passed
@michalvavrik michalvavrik deleted the feature/make-dependabot-update-quarkus-version branch December 22, 2023 08:20
@michalvavrik michalvavrik mentioned this pull request Jan 17, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants