Allow to disable Linux containers detection execution condition as it can provide false positives when Docker host strategy is used and no CLI is available #996
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Camel Quarkus QE does not install Docker on (some of?) their Windows machines, nor they start Docker on machines that only run OpenShift tests (this part is strange, because condition is only run for
@QuarkusScenario
but I'd need reproducer and time to be worried about OCP), therefore check for Docker CLI can give false positives when only DOCKER_HOST is set, but there is no Docker CLI installed.My suggestion is that unless Camel Quarkus QE really needs this feature, we only add an option to disable this condition evaluation on Windows. We added this condition to be able to run tests on Windows when Docker is available and at the still time to run TS on Windows when Docker is not available.
Please check the relevant options
run tests
phrase in comment)Checklist: