Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to disable Linux containers detection execution condition as it can provide false positives when Docker host strategy is used and no CLI is available #996

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented Dec 21, 2023

Summary

Camel Quarkus QE does not install Docker on (some of?) their Windows machines, nor they start Docker on machines that only run OpenShift tests (this part is strange, because condition is only run for @QuarkusScenario but I'd need reproducer and time to be worried about OCP), therefore check for Docker CLI can give false positives when only DOCKER_HOST is set, but there is no Docker CLI installed.

My suggestion is that unless Camel Quarkus QE really needs this feature, we only add an option to disable this condition evaluation on Windows. We added this condition to be able to run tests on Windows when Docker is available and at the still time to run TS on Windows when Docker is not available.

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik michalvavrik changed the title Allow to disable Linux containers detection exec con Allow to disable Linux containers detection execution condition as it can provide false positives when Docker host strategy is used and no CLI is available Dec 21, 2023
Copy link
Collaborator

@llowinge llowinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for proactive solution.

@michalvavrik michalvavrik merged commit 36d327d into quarkus-qe:main Dec 22, 2023
7 checks passed
@michalvavrik michalvavrik deleted the feature/allow-to-disable-docker-detection branch December 22, 2023 08:19
@michalvavrik michalvavrik mentioned this pull request Jan 17, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants