Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Camel example external applications #906

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

mjurc
Copy link
Member

@mjurc mjurc commented Oct 14, 2023

Summary

https://github.com/apache/camel-quarkus-examples.git is now on Quarkus 3.y, so we should be fine re-enabling them.

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@mjurc mjurc requested a review from jedla97 October 14, 2023 22:35
@mjurc mjurc self-assigned this Oct 14, 2023
@mjurc
Copy link
Member Author

mjurc commented Oct 14, 2023

run tests

@jedla97
Copy link
Member

jedla97 commented Oct 16, 2023

run tests

Copy link
Member

@jedla97 jedla97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for enabling these! LGTM!
For openshift error, by go trough them, I see there is no problem caused by PR (all seems as intermittent).

@jedla97 jedla97 merged commit c76fd88 into quarkus-qe:main Oct 16, 2023
7 of 9 checks passed
@mjurc mjurc deleted the enable-camel-examples branch August 27, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants