Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the disable test affected by quarkusio/quarkus#35288 #895

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

jedla97
Copy link
Member

@jedla97 jedla97 commented Oct 4, 2023

Summary

Enabling the the tests affected by quarkusio/quarkus#35288. Tested it locally and it worked so seems that the issue is resolved.

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@jedla97 jedla97 requested a review from rsvoboda October 4, 2023 14:24
@jedla97
Copy link
Member Author

jedla97 commented Oct 4, 2023

run tests

@rsvoboda
Copy link
Member

rsvoboda commented Oct 4, 2023

So quarkusio/quarkus#35288 can be closed?

Copy link
Member

@rsvoboda rsvoboda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is green including OpenShift runs, merging.

@rsvoboda rsvoboda merged commit 10f3f64 into quarkus-qe:main Oct 4, 2023
7 checks passed
@rsvoboda
Copy link
Member

rsvoboda commented Oct 4, 2023

@jedla97 so quarkusio/quarkus#35288 can be closed?

I checked TS and there are several tests disabled too:

http/http-minimum-reactive/src/test/java/io/quarkus/ts/http/minimum/reactive/ServerlessExtensionDockerBuildStrategyOpenShiftHttpMinimumReactiveIT.java:@Disabled("https://github.com/quarkusio/quarkus/issues/35288")
http/http-minimum-reactive/src/test/java/io/quarkus/ts/http/minimum/reactive/ServerlessExtensionOpenShiftHttpMinimumReactiveIT.java:@Disabled("https://github.com/quarkusio/quarkus/issues/35288")
http/http-minimum/src/test/java/io/quarkus/ts/http/minimum/ServerlessExtensionDockerBuildStrategyOpenShiftHttpMinimumIT.java:@Disabled("https://github.com/quarkusio/quarkus/issues/35288")
http/http-minimum/src/test/java/io/quarkus/ts/http/minimum/ServerlessExtensionOpenShiftHttpMinimumIT.java:@Disabled("https://github.com/quarkusio/quarkus/issues/35288")
super-size/many-extensions/src/test/java/io/quarkus/ts/many/extensions/ServerlessExtensionDockerBuildStrategyOpenShiftManyExtensionsIT.java:@Disabled("https://github.com/quarkusio/quarkus/issues/35288")
super-size/many-extensions/src/test/java/io/quarkus/ts/many/extensions/ServerlessExtensionOpenShiftManyExtensionsIT.java:@Disabled("https://github.com/quarkusio/quarkus/issues/35288")

pls prepare PR for it

@jedla97
Copy link
Member Author

jedla97 commented Oct 4, 2023

@rsvoboda already did PR quarkus-qe/quarkus-test-suite#1461

For that issue, yes I think it can be closed. I'll close it after the testsuite PR is merged.

@jedla97 jedla97 deleted the enable-tests branch April 25, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants