Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add native released run to PR workflow #894

Merged

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented Oct 2, 2023

Summary

closes #886

  • Quarkus version is the released one as we already run daily's with 999-SNAPSHOT but don't check released one. Running both seems expensive (waiting time).
  • No sense to check for Quarkus 1.x version as thanks to Jakarta migration there is no chance it would work anyway
  • Don't validate framework twice, instead store result as maven repo, which allows me in next run not to re-run "framework" profile anyway (yes, it's very fast, but when I specify -pl examples/xyz it wouldn't run)

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik michalvavrik requested review from mjurc and removed request for mjurc October 3, 2023 06:59
@michalvavrik michalvavrik force-pushed the feature/add-native-run-to-pr-ci branch from 272b9c3 to 3e61fc4 Compare October 3, 2023 07:41
@rsvoboda rsvoboda requested a review from mjurc October 3, 2023 07:54
@michalvavrik
Copy link
Member Author

Seems like a network blips, will rerun.

Copy link
Member

@mjurc mjurc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for making this workflow better.

@mjurc mjurc merged commit 365a4c3 into quarkus-qe:main Oct 3, 2023
7 checks passed
@michalvavrik michalvavrik deleted the feature/add-native-run-to-pr-ci branch October 3, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PR CI workflow should check native mode as well
2 participants