-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove rollout from deployment and bump Quarkus to 3.5.0.CR1 #889
Conversation
run tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It really does seem extraneous, good catch, as the doInit
waits for the service.
Let's see what the CI says.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like the rollout wasn't all that redundant after all - can you look at the CI failures? All of the tests that failed use the resource managed by this deployment strategy.
@mjurc we run nightly with I am not sure if this behavior of fabirc8 constitutes a bug, though |
Let's hold off merging this in until after we branch out for 3.2 and we update to Quarkus with that version in the main, then. |
3.4.2 is still bugged |
Rollout is only used for deployment via container registry, but tests are working fine even without it. At the same time, it often causes hard-to-reproduce bugs, with "Failure executing: PATCH at: <...>the object has been modified" exception
5097590
to
496489f
Compare
run tests |
1 similar comment
run tests |
35acf34
to
302c201
Compare
run tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are only 2 failures left, I think they are related and I'm going to investigate them separately because this PR is already fixing tests and we need to move with this. Thanks for contribution. We will definitely need to check TS as well before we proceed with release. I'm going to take care of it.
I need to bump Quarkus version because it is very much related. |
JVM failure fixed here #912. |
One of OC tests fixed here #915, I'll debug the other one tomorrow. |
Summary
Rollout is only used for deployment via container registry, but tests are working fine even without it. At the same time, it often causes hard-to-reproduce bugs, with "Failure executing: PATCH at: <...>the object has been modified" exception
Please check the relevant options
run tests
phrase in comment)Checklist: