Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give tests access to inner Docker container if truly necessary #877

Conversation

michalvavrik
Copy link
Member

Summary

I need to execute some actions on container post start (see here quarkusio/quarkus#35336 (comment), btw it didn't in fact solve my problems :-( so far) and I'd like bare metals to have access to Docker container if really necessary. It is not great option for it's bare metal Docker specific, but this option is available for only very rare cases. The way I use it, I use io.quarkus.test.bootstrap.BaseService#onPostStart and do org.testcontainers.containers.ContainerState#execInContainer(java.lang.String...).

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik
Copy link
Member Author

Failures not related.

Copy link
Member

@mjurc mjurc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok at first glance, let's see how the CI turns out

@michalvavrik
Copy link
Member Author

Seen these failures already here #876, hence unrelated.

@michalvavrik michalvavrik merged commit 6b1c2fb into quarkus-qe:main Sep 15, 2023
3 of 5 checks passed
@michalvavrik michalvavrik deleted the feature/allow-access-to-inner-docker-container branch September 15, 2023 12:50
@michalvavrik michalvavrik mentioned this pull request Sep 15, 2023
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants