Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump io.confluent:kafka-avro-serializer from 7.3.4 to 7.5.0 #862

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 23, 2023

Bumps io.confluent:kafka-avro-serializer from 7.3.4 to 7.5.0.

Commits

Most Recent Ignore Conditions Applied to This Pull Request
Dependency Name Ignore Conditions
io.confluent:kafka-avro-serializer [>= 7.4.a, < 7.5]

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Aug 23, 2023
@QuarkusQE
Copy link
Contributor

Can one of the admins verify this patch?

@rsvoboda
Copy link
Member

confluentinc/schema-registry@v7.3.4...v7.5.0 has a lot of changes

@michalvavrik @mjurc CI is green, do you want to check more things or it should be safe to merge?

@michalvavrik
Copy link
Member

michalvavrik commented Aug 25, 2023

confluentinc/[email protected] has a lot of changes

@michalvavrik @mjurc CI is green, do you want to check more things or it should be safe to merge?

I think it can be very sensitive, we ha problems with right version of kavka-avro-serializer in past. I'm going to test it against OCP first (from my computer, AFAICT it doesn't work for dependabot PRs to run OCP tests).

@michalvavrik
Copy link
Member

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/maven/io.confluent-kafka-avro-serializer-7.5.0 branch from a0465bf to 04737e5 Compare September 1, 2023 16:54
@michalvavrik
Copy link
Member

@dependabot recreate

@dependabot dependabot bot force-pushed the dependabot/maven/io.confluent-kafka-avro-serializer-7.5.0 branch from 04737e5 to 565251b Compare September 9, 2023 13:17
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 11, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@michalvavrik michalvavrik reopened this Sep 11, 2023
@dependabot dependabot bot force-pushed the dependabot/maven/io.confluent-kafka-avro-serializer-7.5.0 branch from 565251b to 668ef22 Compare September 11, 2023 21:56
@michalvavrik
Copy link
Member

@dependabot rebase

Bumps [io.confluent:kafka-avro-serializer](https://github.com/confluentinc/schema-registry) from 7.3.4 to 7.5.0.
- [Commits](https://github.com/confluentinc/schema-registry/commits)

---
updated-dependencies:
- dependency-name: io.confluent:kafka-avro-serializer
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/maven/io.confluent-kafka-avro-serializer-7.5.0 branch from 668ef22 to 12423e7 Compare September 19, 2023 12:24
Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with OCP 4.13 on my workstation.

@michalvavrik michalvavrik merged commit 3fae38d into main Sep 19, 2023
5 checks passed
@michalvavrik michalvavrik deleted the dependabot/maven/io.confluent-kafka-avro-serializer-7.5.0 branch September 19, 2023 17:54
@michalvavrik
Copy link
Member

I think we should have native run in CI. I didn't test this in native and now daily's are failing. https://quarkus.io/version/main/guides/kafka-schema-registry-avro#confluent explicitly says in native at most 7.2.X is supported. I'm going to revert this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants