Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable OpenShift tests, which are broken in Quarkus 3.2.0.Final #830

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

fedinskiy
Copy link
Contributor

@fedinskiy fedinskiy commented Jul 11, 2023

Summary

  1. Openshift extension does not create a service for a management interface quarkusio/quarkus#34645

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@fedinskiy fedinskiy requested a review from michalvavrik July 11, 2023 15:06
@fedinskiy fedinskiy force-pushed the feature/320_and_fix branch 6 times, most recently from 467fa8b to 6376f6f Compare July 11, 2023 16:12
@fedinskiy fedinskiy force-pushed the feature/320_and_fix branch from 6376f6f to e38ace2 Compare July 11, 2023 16:38
Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @fedinskiy that disables tests, no 3.2.0 bump. It is probably not intentional, right? I don't mind though as far as we consider it preparation for 3.2.0 bump. I'm going to change title and desc and merge it.

@michalvavrik michalvavrik changed the title Update Quarkus to version 3.2.0 and disable tests, which are broken because of it Disable OpenShift tests, which are broken in Quarkus 3.2.0.Final Jul 11, 2023
@michalvavrik michalvavrik merged commit 3fdd08a into quarkus-qe:main Jul 11, 2023
@michalvavrik
Copy link
Member

Please create follow-up PR.

@fedinskiy
Copy link
Contributor Author

@michalvavrik that is correct, it looks like 3.2.0 has changes, which broke our format checks.

But I would prefer to run some tests on Openshift before merging this one :)

@fedinskiy fedinskiy deleted the feature/320_and_fix branch July 11, 2023 20:47
@michalvavrik
Copy link
Member

But I would prefer to run some tests on Openshift before merging this one :)

I didn't run OCP tests because this PR only disables them, I can't imagine how it can break anything. Give me a hint and I shall be smarter next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants