Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Quarkus to 3.2.0.CR1 #817

Closed
wants to merge 2 commits into from
Closed

Bump Quarkus to 3.2.0.CR1 #817

wants to merge 2 commits into from

Conversation

fedinskiy
Copy link
Contributor

Summary

Bump Quarkus to 3.2.0.CR1
Remove workaround from #814

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

fedinskiy added 2 commits June 22, 2023 16:42
@fedinskiy
Bump Quarkus to 3.2.0.CR1
f08b9b6
@fedinskiy
Remove workaround
953d933 
Previous PR[1] added a workaround
to address incompatibilitybetween different versions of fabiric8
Due to update of Quarkus version, it can now be removed
[1] quarkus-qe#814
@fedinskiy fedinskiy requested a review from michalvavrik June 22, 2023 15:19
@fedinskiy
Copy link
Contributor Author

run tests

@fedinskiy fedinskiy changed the title Bump/quarkus 320 cr1 Bump Quarkus to 3.2.0.CR1 Jun 22, 2023
michalvavrik
michalvavrik approved these changes Jun 22, 2023
View reviewed changes
Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea

@michalvavrik
Copy link
Member

I don't have time to analyze OCP failures ATM, so I won't merge it before I do (or someone else analyze them).

@michalvavrik
Copy link
Member

Please feel free to remove the label when you analyzed failures, thx.

@fedinskiy
Copy link
Contributor Author

Hmm, there are multiple errors "Connection was closed" which can be reproduced on RHEL, but can not be reproduced on Fedora. Some weird network behavior?

@fedinskiy
Copy link
Contributor Author

@michalvavrik the issue: quarkusio/quarkus#34276

@michalvavrik
Copy link
Member

Thanks @fedinskiy , in that case we should wait till they fix it. WDYT?

@fedinskiy fedinskiy closed this Jul 11, 2023
@fedinskiy fedinskiy mentioned this pull request Jul 14, 2023
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalvavrik michalvavrik michalvavrik approved these changes

Assignees
No one assigned
Labels
DON'T MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fedinskiy @michalvavrik