Fix compilation failure due to removed method #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fabric8 team removed[1][2] constructors, which we were using to create Openshift client Switched to other methods. This change was brought to Quarkus with this update[3] [1] fabric8io/kubernetes-client@6d7db80#diff-92a1266d167b46838301a64f043de2895376ebf7ec810e7769d641d2fed6f511L227-L246 [2] fabric8io/kubernetes-client#4662 [3] quarkusio/quarkus#33767
|
run tests |
michalvavrik
approved these changes
Jun 14, 2023
fedinskiy
added a commit
to fedinskiy/quarkus-test-framework
that referenced
this pull request
Jun 15, 2023
Follow up to [1] caused by the same breaking changes[2]. Added some tests to cover affected scenarios from the TS. [1] quarkus-qe#803 [2] fabric8io/kubernetes-client#4662
10 tasks
fedinskiy
added a commit
to fedinskiy/quarkus-test-framework
that referenced
this pull request
Jun 16, 2023
See [1] and [2] for details. [1] quarkus-qe#803 [2] fabric8io/kubernetes-client#4662
This was referenced Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fabric8 team removed[1][2] constructors, which we were using to create Openshift client
Switched to other methods.
This change was brought to Quarkus with this update[3]
[1] fabric8io/kubernetes-client@6d7db80#diff-92a1266d167b46838301a64f043de2895376ebf7ec810e7769d641d2fed6f511L227-L246
[2] fabric8io/kubernetes-client#4662
[3] quarkusio/quarkus#33767
Please check the relevant options
run testsphrase in comment)Checklist: