Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use various GRPC probe options as build-time properties #772

Merged
merged 1 commit into from
May 4, 2023
Merged

Use various GRPC probe options as build-time properties #772

merged 1 commit into from
May 4, 2023

Conversation

fedinskiy
Copy link
Contributor

Summary

Required for coverage of quarkusio/quarkus#32113

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@fedinskiy fedinskiy requested a review from michalvavrik May 4, 2023 14:17
@fedinskiy fedinskiy mentioned this pull request May 4, 2023
Closed
9 tasks
@fedinskiy
Copy link
Contributor Author

run tests

michalvavrik
michalvavrik approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michalvavrik
Copy link
Member

OC native failure not related

@michalvavrik michalvavrik merged commit fa81c0c into quarkus-qe:main May 4, 2023
@michalvavrik michalvavrik mentioned this pull request May 16, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalvavrik michalvavrik michalvavrik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fedinskiy @michalvavrik