Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Picocli test failures in native mode by passing args to executable #705

Merged
merged 1 commit into from
Mar 13, 2023
Merged

Fix Picocli test failures in native mode by passing args to executable #705

merged 1 commit into from
Mar 13, 2023

Conversation

michalvavrik
Copy link
Member

Summary

Daily runs are failing in native mode over Picocli examples ever since #702 was merged. We need to pass 'quarkus.args' to native executable too.

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik michalvavrik requested a review from pjgg March 12, 2023 10:21
pjgg
pjgg approved these changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@pjgg pjgg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pjgg pjgg merged commit c1be306 into quarkus-qe:main Mar 13, 2023
@michalvavrik michalvavrik deleted the feature/fix-picocli-native-failures branch March 13, 2023 08:12
@michalvavrik michalvavrik mentioned this pull request Mar 13, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjgg pjgg pjgg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michalvavrik @pjgg