Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix name of trace operations #695

Merged
merged 1 commit into from
Mar 7, 2023
Merged

Conversation

fedinskiy
Copy link
Contributor

Names of opeartions now include HTTP method.
Our tests were not expecting that and failed during daily CI runs.

Summary

(Summarize the problem solved by this PR, and how to verify it manually)

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @fedinskiy , thanks for looking at it. This solution won't do till Alpha5 is released with OTEL changes. You have 2 options:

  • enable the test only for 999-SNAPSHOT
  • correct your expectations according to Quarkus version obtained from Version.getVersion()

One way or another, we need TODO to remove this workaround

Names of opeartions now include HTTP method.
Our tests were not expecting that and failed during daily CI runs.
@michalvavrik michalvavrik merged commit ec38340 into quarkus-qe:main Mar 7, 2023
@fedinskiy fedinskiy deleted the fix/daily branch March 7, 2023 18:10
@pjgg pjgg mentioned this pull request Mar 8, 2023
1 task
@michalvavrik michalvavrik mentioned this pull request Mar 13, 2023
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants