Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache the uri of service #625

Merged
merged 1 commit into from
Dec 15, 2022
Merged

Cache the uri of service #625

merged 1 commit into from
Dec 15, 2022

Conversation

fedinskiy
Copy link
Contributor

Summary

This is a port of the fix[1] for occasional failures in 2.7 Interop tests

[1] #623

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@fedinskiy fedinskiy requested a review from pjgg December 14, 2022 13:24
@fedinskiy
Cache the uri of service
5d8fc7c 
This is a port of the fix[1] for occasional failures in 2.7 Interop tests

[1] quarkus-qe#623
@fedinskiy
Copy link
Contributor Author

run tests

@fedinskiy
Copy link
Contributor Author

To filter CI failures I created an empty PR[1] to compare their runs
Openshift native failures are identical:
https://main-jenkins-csb-quarkusqe.apps.ocp-c1.prod.psi.redhat.com/job/quarkus-main-rhel8-jdk11-openshift-tf-native-githubci/216/ (this)
https://main-jenkins-csb-quarkusqe.apps.ocp-c1.prod.psi.redhat.com/job/quarkus-main-rhel8-jdk11-openshift-tf-native-githubci/217/#showFailuresLink (control)

JVM failures are different(baseline have more failures, than this one):
https://main-jenkins-csb-quarkusqe.apps.ocp-c1.prod.psi.redhat.com/job/quarkus-main-rhel8-jdk11-openshift-tf-jvm-githubci/237/testReport/ (this)
https://main-jenkins-csb-quarkusqe.apps.ocp-c1.prod.psi.redhat.com/job/quarkus-main-rhel8-jdk11-openshift-tf-jvm-githubci/238/testReport/ (control)

Therefore I consider, that these failures are unrelated (but our tests are extremely unstable)

[1] #626

pjgg
pjgg approved these changes Dec 15, 2022
View reviewed changes
Copy link
Contributor

@pjgg pjgg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pjgg pjgg merged commit d668b5d into quarkus-qe:main Dec 15, 2022
jsmrcka added a commit to jsmrcka/quarkus-test-suite that referenced this pull request Jan 5, 2023
@jsmrcka
Bump quarkus.qe.framework.version from 1.2.0.Beta13 to 1.2.0.Final
f5ad726 
Motivation:
- quarkus-qe/quarkus-test-framework#625 - merged
in FW `1.2.0.Beta16`, fixes interop OCP failures.
This was referenced Jan 5, 2023
Merged
Merged
fedinskiy pushed a commit to quarkus-qe/quarkus-test-suite that referenced this pull request Jan 11, 2023
@jsmrcka @fedinskiy
Bump quarkus.qe.framework.version from 1.2.0.Beta13 to 1.2.0.Final
e680c8e 
Motivation:
- quarkus-qe/quarkus-test-framework#625 - merged
in FW `1.2.0.Beta16`, fixes interop OCP failures.
jsmrcka added a commit to jsmrcka/quarkus-test-framework that referenced this pull request Jan 19, 2023
@jsmrcka
Fix OpenShift resource URI caching - clear cache on service stop
f59e642 
Prevents the cached value from distorting status checks on stopped
resources.

This fixes `infinispan-client` failures observed in e.g.
quarkus-qe/quarkus-test-suite#975.

This is a follow-up to
quarkus-qe#625,
which introduced the caching in order to fix issues in INTEROP
environment. See e.g.
https://mpts-prod.psi.redhat.com/dashboard/run/?id=8896.
@jsmrcka jsmrcka mentioned this pull request Jan 19, 2023
Merged
10 tasks
pjgg pushed a commit to pjgg/quarkus-test-framework that referenced this pull request Jan 30, 2023
@jsmrcka
Fix OpenShift resource URI caching - clear cache on service stop
6666c11 
Prevents the cached value from distorting status checks on stopped
resources.

This fixes `infinispan-client` failures observed in e.g.
quarkus-qe/quarkus-test-suite#975.

This is a follow-up to
quarkus-qe#625,
which introduced the caching in order to fix issues in INTEROP
environment. See e.g.
https://mpts-prod.psi.redhat.com/dashboard/run/?id=8896.

(cherry picked from commit f59e642)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjgg pjgg pjgg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fedinskiy @pjgg