Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to infispan 14 #622

Merged
merged 1 commit into from
Dec 13, 2022
Merged

Add support to infispan 14 #622

merged 1 commit into from
Dec 13, 2022

Conversation

pjgg
Copy link
Contributor

@pjgg pjgg commented Dec 2, 2022

Summary

  • Update example/infinispan in order to point to version 14
  • Make "SLASH" constant platform independent
  • Fix a small issue related to "resource_with_destination" property that wasn't working on baremetal (now behaves exactly the same as OpenShift implementation).

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@pjgg pjgg requested a review from fedinskiy December 12, 2022 19:16
fedinskiy
fedinskiy approved these changes Dec 13, 2022
View reviewed changes
Copy link
Contributor

@fedinskiy fedinskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small style remark, but otherwise LGTM.

examples/infinispan/src/test/java/io/quarkus/qe/books/UsingJksInfinispanBookCacheIT.java Outdated Show resolved Hide resolved
@pjgg pjgg merged commit 224a5ac into quarkus-qe:main Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedinskiy fedinskiy fedinskiy approved these changes

@michalvavrik michalvavrik Awaiting requested review from michalvavrik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pjgg @fedinskiy