Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support OpenShift certificate serving used with TLS registry #1270

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented Aug 31, 2024

Summary

Adding support for certificate serving so that we can test this section of the Quarkus TLS registry extension reference: https://quarkus.io/guides/tls-registry-reference#utilizing-openshift-serving-certificates

I have only implemented it for template-based builder. I think it should be technically possible to test this with extension-based builder, but probably need to configure Quarkus OpenShift extension specific properties inside of the test. It is not really relevant as I care about TLS registry reference verification ATM.

Regarding limitation to Quarkus runtime inside of this PR. I have added it so that I avoid (not necessarily) possible side-effects. I am just implementing what I need and if someone needs more, they need to extend functionality.

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Release (follows conventions described in the RELEASE.md)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik
Copy link
Member Author

run tests

@michalvavrik michalvavrik requested a review from gtroitsk August 31, 2024 21:55
@michalvavrik michalvavrik added the triage/backport-1.5? Quarkus 3.15 stream label Aug 31, 2024
@michalvavrik michalvavrik force-pushed the feature/openshift-tls-certificate-serving branch from 571477e to 6e483fc Compare September 1, 2024 06:00
@michalvavrik
Copy link
Member Author

run tests

@michalvavrik michalvavrik force-pushed the feature/openshift-tls-certificate-serving branch from 6e483fc to e878ab5 Compare September 1, 2024 16:15
Copy link
Member

@gtroitsk gtroitsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thank you!

@michalvavrik michalvavrik merged commit 6d2a583 into quarkus-qe:main Sep 1, 2024
8 checks passed
@michalvavrik michalvavrik deleted the feature/openshift-tls-certificate-serving branch September 1, 2024 17:42
@michalvavrik michalvavrik removed the triage/backport-1.5? Quarkus 3.15 stream label Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants