Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated app-model methods in QuarkusApplicationManagedResourceBuilder #1206

Merged

Conversation

gtroitsk
Copy link
Member

@gtroitsk gtroitsk commented Jul 18, 2024

Summary

Since Quarkus 3.11.0 some io.quarkus.bootstrap.model.* methods planned to be removed, that was done yesterday. This PR provides fix with its replacement.

Single test in FW that forces dependencies is GreetingResourceIT from blocking-reactive-model module

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Release (follows conventions described in the RELEASE.md)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@gtroitsk gtroitsk requested a review from fedinskiy July 18, 2024 06:12
Copy link
Contributor

@fedinskiy fedinskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Let's see that the CI will tell us

@gtroitsk
Copy link
Member Author

Kafka failure is known issue, I think we can merge it.

@fedinskiy
Copy link
Contributor

run tests

@jedla97
Copy link
Member

jedla97 commented Jul 18, 2024

note: This removal also affected testsuit. Tested it with this fix and it work!

@fedinskiy
Copy link
Contributor

The failures in GH CI are known issue. The failures on OCP are different between two runs, so probably unrelated

@fedinskiy fedinskiy merged commit b951dda into quarkus-qe:main Jul 18, 2024
8 of 10 checks passed
@gtroitsk gtroitsk deleted the fix/update-deprecated-app-model-methods branch July 18, 2024 13:24
@jedla97 jedla97 mentioned this pull request Jul 19, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants