Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Kafka SSL scenarios in FIPS enabled environment by regenerating certs #1088

Merged

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented Apr 18, 2024

Summary

We have in place default p12 keystore for Strimzi vendor that has certs generated with algorithm not supported in FIPS. I can't just override it in tests because they all are expecting one truststore. I have decided to re-generate them and refactor it bit to avoid repetition. It's quite quick.

Sadly, this doesn't fix SASL_SSL scenarios as plain auth mechanism just doesn't work in FIPS. I don't know what to do about that part and in the future there will be follow-up, but this PR will help to to fix SSL scenarios at least.

I am adding support for Docker host porting to localhost that we use for Kafka SSL scenarios to also drop repetition.

This PR should be backwards compatible and should not break anything, I run couple of Kafka modules in TS with it.

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik
Copy link
Member Author

run tests

@michalvavrik michalvavrik force-pushed the feature/fix-kafka-cert-generation branch from 4c3940f to 4fef158 Compare April 18, 2024 19:50
@michalvavrik
Copy link
Member Author

run tests

@michalvavrik michalvavrik force-pushed the feature/fix-kafka-cert-generation branch from 4fef158 to fed3d78 Compare April 18, 2024 20:04
@michalvavrik
Copy link
Member Author

run tests

@michalvavrik michalvavrik requested a review from mjurc April 18, 2024 21:02
@mjurc
Copy link
Member

mjurc commented Apr 18, 2024

run tests

Copy link
Member

@mjurc mjurc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the one nit, I don't see anything wrong about this. Let's see about the CI.

quarkus-test-service-kafka/pom.xml Show resolved Hide resolved
@michalvavrik
Copy link
Member Author

OC jobs are failing but it's not connected to this PR judging by logs. AFAICT I didn't touch anything related to OCP, they have their own builder.

Copy link
Member

@mjurc mjurc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your efforts.

@mjurc mjurc merged commit 0b0ff9b into quarkus-qe:main Apr 19, 2024
8 of 10 checks passed
@michalvavrik michalvavrik deleted the feature/fix-kafka-cert-generation branch April 19, 2024 08:19
@michalvavrik michalvavrik mentioned this pull request Apr 23, 2024
11 tasks
@michalvavrik michalvavrik added the triage/backport-1.4? Quarkus 3.8 stream label Apr 26, 2024
@michalvavrik michalvavrik removed the triage/backport-1.4? Quarkus 3.8 stream label May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants