-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Kafka SSL scenarios in FIPS enabled environment by regenerating certs #1088
Fix Kafka SSL scenarios in FIPS enabled environment by regenerating certs #1088
Conversation
run tests |
4c3940f
to
4fef158
Compare
run tests |
4fef158
to
fed3d78
Compare
run tests |
run tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the one nit, I don't see anything wrong about this. Let's see about the CI.
OC jobs are failing but it's not connected to this PR judging by logs. AFAICT I didn't touch anything related to OCP, they have their own builder. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your efforts.
Summary
We have in place default p12 keystore for Strimzi vendor that has certs generated with algorithm not supported in FIPS. I can't just override it in tests because they all are expecting one truststore. I have decided to re-generate them and refactor it bit to avoid repetition. It's quite quick.
Sadly, this doesn't fix SASL_SSL scenarios as plain auth mechanism just doesn't work in FIPS. I don't know what to do about that part and in the future there will be follow-up, but this PR will help to to fix SSL scenarios at least.
I am adding support for Docker host porting to localhost that we use for Kafka SSL scenarios to also drop repetition.
This PR should be backwards compatible and should not break anything, I run couple of Kafka modules in TS with it.
Please check the relevant options
run tests
phrase in comment)Checklist: