Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use only fully-qualified image names #604

Closed
fedinskiy opened this issue Oct 24, 2022 · 0 comments · Fixed by #606
Closed

Use only fully-qualified image names #604

fedinskiy opened this issue Oct 24, 2022 · 0 comments · Fixed by #606
Assignees
@fedinskiy

Comments

@fedinskiy
Copy link
Contributor

Right now, we use fully-qualified image names in ts, but several constants in FW are using short names, which are not compatible[2] with testcontainers and podman working together.

[1] eg https://github.com/quarkus-qe/quarkus-test-framework/blob/main/quarkus-test-service-kafka/src/main/java/io/quarkus/test/services/containers/model/KafkaVendor.java#L4
[2] testcontainers/testcontainers-java#5998
fedinskiy added a commit to fedinskiy/quarkus-test-framework that referenced this issue Oct 25, 2022
@fedinskiy
Use fully-qualified image names
5790e0a 
Solves quarkus-qe#604
@fedinskiy fedinskiy mentioned this issue Oct 25, 2022
Merged
10 tasks
@fedinskiy fedinskiy linked a pull request Oct 25, 2022 that will close this issue
Use fully-qualified image names #606
Merged
10 tasks
fedinskiy added a commit to fedinskiy/quarkus-test-framework that referenced this issue Oct 25, 2022
@fedinskiy
Use fully-qualified image names
803cd23 
Solves quarkus-qe#604
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fedinskiy fedinskiy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use fully-qualified image names fedinskiy/quarkus-test-framework
1 participant
@fedinskiy