Skip to content

Commit

Permalink
Merge pull request #606 from fedinskiy/fix/full-image-names
Browse files Browse the repository at this point in the history
Use fully-qualified image names
  • Loading branch information
michalvavrik authored Oct 25, 2022
2 parents e054242 + 803cd23 commit cfd33c0
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,11 @@ public String getDisplayName() {

@Override
protected GenericContainer<?> initKafkaContainer() {
return new KafkaContainer(DockerImageName.parse(getKafkaImage() + ":" + getKafkaVersion()))
DockerImageName imageName = DockerImageName
.parse(getKafkaImage() + ":" + getKafkaVersion())
// todo https://github.com/testcontainers/testcontainers-java/issues/5612
.asCompatibleSubstituteFor("confluentinc/cp-kafka");
return new KafkaContainer(imageName)
.withCreateContainerCmdModifier(cmd -> cmd.withName(DockerUtils.generateDockerContainerName()));
}

Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package io.quarkus.test.services.containers.model;

public enum KafkaRegistry {
CONFLUENT("confluentinc/cp-schema-registry", "6.1.1", "/", 8081),
CONFLUENT("docker.io/confluentinc/cp-schema-registry", "6.1.1", "/", 8081),
APICURIO("quay.io/apicurio/apicurio-registry-mem", "2.2.5.Final", "/apis", 8080);

private final String image;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package io.quarkus.test.services.containers.model;

public enum KafkaVendor {
CONFLUENT("confluentinc/cp-kafka", "7.2.2", 9093, KafkaRegistry.CONFLUENT),
CONFLUENT("docker.io/confluentinc/cp-kafka", "7.2.2", 9093, KafkaRegistry.CONFLUENT),
STRIMZI("quay.io/strimzi/kafka", "0.31.1-kafka-3.1.2", 9092, KafkaRegistry.APICURIO);

private final String image;
Expand Down

0 comments on commit cfd33c0

Please sign in to comment.