Move to new Quarkus platform without universe BOM #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshpak
approved these changes
Jul 30, 2021
|
LGTM FakeOIDCServer indeed is not required in 2.1.0.Final, but I can't see devservices launch keycloak server as Docker container (not needed for the purposes of the test, but seems strange as devservices for keycloak are enabled by default) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move to new Quarkus platform without universe BOM
Also dropping usage of FakeOIDCServer as the OIDC extension doesn't need running Keycloak/RHSSO server when not used.