Skip to content
This repository has been archived by the owner on Sep 18, 2023. It is now read-only.

App Metadata needs runtime dependencies of vertx-http #254

Merged
merged 1 commit into from
Apr 2, 2021

Conversation

Sgitario
Copy link
Contributor

At the moment, the bootstrap maven plugin is failing when using 999-SNAPSHOT version.

@Sgitario Sgitario requested a review from rsvoboda March 26, 2021 08:55
@Sgitario
Copy link
Contributor Author

run tests

@Sgitario
Copy link
Contributor Author

The failure is caused by an unrelated issue. Fixed as part of #252.

@Sgitario
Copy link
Contributor Author

The failures in Native are due to timeouts when building in OpenShift. I think we should increase the timeout for Native compilation.
However, this is unrelated to this PR and I think we're good to merge.
cc @rsvoboda

@rsvoboda
Copy link
Member

@Sgitario were you able to identify PR or issue which brought this change?

@Sgitario
Copy link
Contributor Author

@Sgitario were you able to identify PR or issue which brought this change?

I tried to identify what changed was the root cause of this new behaviour, but no luck so far.

@Sgitario
Copy link
Contributor Author

@Sgitario
Copy link
Contributor Author

@rsvoboda Georgios has already helped to clarify why started failing. It was an enhancement of the validation: quarkusio/quarkus#14609
I think we're good to merge this change then.

@Ladicek
Copy link
Contributor

Ladicek commented Mar 30, 2021

Agree, this is the correct thing to do.

@rsvoboda rsvoboda merged commit 2b1a7fb into quarkus-qe:main Apr 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants