-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a scenario with an extension registering many classes #324
Add a scenario with an extension registering many classes #324
Conversation
Thank you for the contribution. I will keep the PR as is till Quarkus issue gets resolved. This test suite is kept in current form without new additions. For Qiuarkus 2 series we moved to https://github.com/quarkus-qe/quarkus-test-suite to unify for both bare metal and OpenShift scenarios. |
@rsvoboda Thx for the info, do you confirm that it is the right place to define a use case to be tested? |
Your PR can land here, no issue with that. Tests from this repo are executed against Quarkus main. If you plan to evolve the test coverage in the future, https://github.com/quarkus-qe/quarkus-test-suite is better place as more people are looking into that repo. |
@essobedo Quarkus PR is merged, so I tried to run the module against Quarkus main quarkusio/quarkus@9666d20 Unfortunately I receive Is there a special way how to run the module? |
I was able to get around the above issue by disabling --- a/024-quarkus-extension-with-many-classes-to-register/deployment/pom.xml
+++ b/024-quarkus-extension-with-many-classes-to-register/deployment/pom.xml
@@ -8,6 +8,9 @@
<relativePath>../pom.xml</relativePath>
</parent>
<artifactId>024-quarkus-extension-with-many-classes-to-register-deployment</artifactId>
+ <properties>
+ <quarkus.generate-code.skip>true</quarkus.generate-code.skip>
+ </properties>
<dependencies>
<dependency>
<groupId>io.quarkus</groupId> The build passes with Quarkus main. But it also passes with 2.16.0.Final |
Weird, let me ckeck |
Co-authored-by: Rostislav Svoboda <[email protected]>
@rsvoboda Your change is correct, I included it in my PR and added you as co-author. Regarding your test, it is normal that it works because the bug only happen in native mode not in JVM mode, add |
Hum I don't have the right email to add you as co-author |
With main I just get many warnings like |
@rsvoboda yes indeed, it’s the expected behavior. |
Will merge once CI finishes. |
A scenario to illustrate quarkusio/quarkus#29693