-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vertx Logger and ConfigProperties was deprecated #215
Conversation
5d44df6
to
16bb2bb
Compare
Looks like ConfigProperties is able to read child properties from a parent class configuration:
application.properties
But the same scenario with
|
@pjgg this is candidate for a bug report. The transition should be smooth for the users. |
Issue: quarkusio/quarkus#17545 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the plan with the different behavior of @ConfigMapping
? (See quarkusio/quarkus#17545 (comment), which corresponds with https://smallrye.io/docs/smallrye-config/main/mapping/mapping.html, also referenced in https://quarkus.io/version/main/guides/config#inject-the-configuration.)
I see no way to smoothly transition from the deprecated annotation.
010-quarkus-opentracing-reactive-grpc/src/test/java/io/quarkus/qe/GrpcPingPongResourceTest.java
Outdated
Show resolved
Hide resolved
16bb2bb
to
4b5123e
Compare
The new implementation is great!. To me makes even more sense than the old one from a conceptual point of view. For example the above code will look something like this:
But the point is that this change is a breaking change that will makes fail all the existing applications that use this feature. So, we should think about a smooth transition. |
7153345
to
3e091e8
Compare
3e091e8
to
9b99d95
Compare
Upgrade deprecated code:
io.quarkus.arc.config.ConfigProperties
was deprecatedVertx
Logger was deprecated