Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kamelet module #210

Merged
merged 1 commit into from
May 27, 2021
Merged

Add Kamelet module #210

merged 1 commit into from
May 27, 2021

Conversation

pjgg
Copy link
Contributor

@pjgg pjgg commented May 19, 2021

Quarkus-kamelet provide you support to interacting with Camel routes templates.
The aim of this module is to cover the following Kamelet scenarios:

  • Camel producers, those scenarios where your service produces events and are consumed by a camel route
  • Camel consumers, those scenarios where your service consumes a camel route
  • Chain routes multiples routes
  • Load application properties as routes bodies
  • Validate Kamelet resources as ocp/k8s kamelet yamls(routes-temapltes, routes-bindings...)

This PR also cover this issue: quarkusio/quarkus#16954

@pjgg pjgg requested a review from rsvoboda May 19, 2021 11:31
@@ -0,0 +1,16 @@
# Quarkus - Kamelet

The aim of this module is to cover all kamelet scenarios.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"all" is too vague, please list the scenarios and highlight the one hit by Camel Quarkus team

@rsvoboda
Copy link
Member

This should fail with 1.11.6.Final, but it does not!

Running mvn clean verify -f 023-quarkus-kamelet -Dquarkus.platform.version=1.11.6.Final -Dquarkus-plugin.version=1.11.6.Final

@pjgg
Copy link
Contributor Author

pjgg commented May 19, 2021

This should fail with 1.11.6.Final, but it does not!

Running mvn clean verify -f 023-quarkus-kamelet -Dquarkus.platform.version=1.11.6.Final -Dquarkus-plugin.version=1.11.6.Final

Yes that is true, but in order to make it fails you should run your test against camel-quarkus-kamelet:1.9.0-SNAPSHOT

These tests reproduce the original issue:

Caused by: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: Cannot serialise field parent on object SetBody[exchangeProperty{CamelTimerCounter}] as setter and getters were different types
        at io.quarkus.deployment.recording.BytecodeRecorderImpl.loadComplexObject(BytecodeRecorderImpl.java:1371)
        at io.quarkus.deployment.recording.BytecodeRecorderImpl.loadObjectInstanceImpl(BytecodeRecorderImpl.java:956)
        at io.quarkus.deployment.recording.BytecodeRecorderImpl.loadObjectInstance(BytecodeRecorderImpl.java:548)
        at io.quarkus.deployment.recording.BytecodeRecorderImpl.loadComplexObject(BytecodeRecorderImpl.java:1114)
        at io.quarkus.deployment.recording.BytecodeRecorderImpl.loadObjectInstanceImpl(BytecodeRecorderImpl.java:956)
        at io.quarkus.deployment.recording.BytecodeRecorderImpl.loadObjectInstance(BytecodeRecorderImpl.java:548)
        at io.quarkus.deployment.recording.BytecodeRecorderImpl.writeBytecode(BytecodeRecorderImpl.java:447)
        ... 12 more

This issue is already fixed (If you run it against the latest version of Quarkus 1.11), but this fix show up a new issue (An stackoverflow exception) caused by camel-quarkus-kamelet:1.9.0-SNAPSHOT . They already know it, and are working on it.

IF you run the current test against camel-quarkus-kamelet:1.8.1 is going to work as expected.

@rsvoboda rsvoboda merged commit 4f9615a into quarkus-qe:main May 27, 2021
@pjgg pjgg mentioned this pull request Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants