Reproducer for quarkus/issues/15025: Quarkus keeps dead database connect #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kyrylo is sick |
|
Adding "DO NOT MERGE" as it's failing in CI... I'm investigating this. |
Sgitario
force-pushed
the
reproducer_15025
branch
2 times, most recently
from
cff5ce7 to
bc9a17a
Compare
|
Fixed by adding DB_CLOSE into the jdbc url. It seems that when we stop/start the database connection, this property is necessary. |
Sgitario
force-pushed
the
reproducer_15025
branch
from
bc9a17a to
459f1ae
Compare
|
Closing as stopping/starting the database is making the test unestable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reproducer for quarkusio/quarkus#15025: Quarkus keeps dead database connections in its connection pool.
The idea is to keep restarting the database and checking the idle connection pool. Before each restart, we need to call the health check endpoint to trigger the issue.
This is working fine in 999-SNAPSHOT, but not in 1.13.0.Final (as expected as the fix is not part of this release):
Works:
Not work: