Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure asciidoc works as expected #169

Closed
ia3andy opened this issue Oct 10, 2024 · 16 comments · Fixed by #203
Closed

Make sure asciidoc works as expected #169

ia3andy opened this issue Oct 10, 2024 · 16 comments · Fixed by #203
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@ia3andy
Copy link
Contributor

ia3andy commented Oct 10, 2024

No description provided.

@ia3andy ia3andy added this to the 1.0 milestone Oct 10, 2024
@ia3andy
Copy link
Contributor Author

ia3andy commented Oct 10, 2024

@mkouba do we have a qute-web release with it?

@mcruzdev
Copy link
Member

Good issue!

@mkouba
Copy link

mkouba commented Oct 10, 2024

@mkouba do we have a qute-web release with it?

I will do a release (with both asciidoc and md) tomorrow. It will be 3.2.0.

@ia3andy
Copy link
Contributor Author

ia3andy commented Oct 10, 2024

@mcruzdev would you try to add this: quarkiverse/quarkus-qute-web#106 before the release?

@mcruzdev
Copy link
Member

@mkouba when are you planning to do the release?

@ia3andy of course!

@ia3andy
Copy link
Contributor Author

ia3andy commented Oct 10, 2024

@mkouba when are you planning to do the release?

@ia3andy of course!

he just answered (tomorrow)

@mcruzdev
Copy link
Member

mcruzdev commented Oct 10, 2024

Okay, we have time! haha

@mkouba
Copy link

mkouba commented Oct 11, 2024

FYI qute-web 3.2.0 is in the Maven central :D

@ia3andy
Copy link
Contributor Author

ia3andy commented Oct 14, 2024

Ok I am giving it a try

@ia3andy ia3andy self-assigned this Oct 14, 2024
@jtama
Copy link
Member

jtama commented Oct 22, 2024

Can I help in any way to make asciidoc a thing in roq ?

@ia3andy
Copy link
Contributor Author

ia3andy commented Oct 22, 2024

Ok @jtama:

Then you should be ready to try it :)

@ia3andy ia3andy assigned jtama and unassigned ia3andy Oct 22, 2024
@jtama
Copy link
Member

jtama commented Oct 22, 2024

Ok I will try that and make a PR once it works.

@jtama
Copy link
Member

jtama commented Oct 22, 2024

So If I had the qute-web-asciidoc to execute tests in the roq-fontmatter it works:

  • The asciidoc content gets pickedup and html is correctly generated.

But in the qarukus blog if I had the quarkus-roq-plugin-asciidoc -which is basically an empty shell pulling dependency to qute-web-asciidoc- the adoc content isn't picked up. I have to admin I don't even understand at which point the conversion is done, which is a bit confusing for me.

@jtama
Copy link
Member

jtama commented Oct 22, 2024

Nevermind my previous comment. It works!

Let me add docs and test where needed. And I will provide a PR.

@ia3andy
Copy link
Contributor Author

ia3andy commented Oct 22, 2024

@jtama yeah for now it's an empty shell but we might move the logic to it at some point and also for Markdown.. I am not sure yet, so let's keep the option open..

@ia3andy
Copy link
Contributor Author

ia3andy commented Oct 22, 2024

FYI, the scanner processor is generating a new Qute template with the appropriate markup Qute tag, then Qute is doing the rest using the qute-web extension that allow to use asciidoc and markdown tags.

@melloware melloware added the enhancement New feature or request label Oct 22, 2024
jtama added a commit to jtama/quarkus-roq-asciidoc that referenced this issue Oct 22, 2024
jtama added a commit to jtama/quarkus-roq-asciidoc that referenced this issue Oct 22, 2024
jtama added a commit to jtama/quarkus-roq-asciidoc that referenced this issue Oct 22, 2024
ia3andy pushed a commit that referenced this issue Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants