Renard validator(MyValidationInterceptor) should not apply on rest enpoint that not extends renarde.Controller #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s renarde Controller else throw ResteasyReactiveViolationException. So rest reactive endpoint validation will work as normal
FroMage
requested changes
Oct 31, 2024
|
@FroMage the test was added. |
|
Perfect. A note in the docs? :) I can add it for you if you prefer. |
Yes, please! That would be great, thank you. @FroMage |
FroMage
added a commit
that referenced
this pull request
Nov 25, 2024
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have 2 controller
when I apply @Valid on 1. I observe that MyValidationInterceptor add ConstrainViolation to validation.error event if my controller does not extends renard Controller. So I can't report error back to user like normal rest . and endpoint method get called even if validate fail (it is OK for htmx,html response)